Skip to content

intersection: show types in exception due to invalid arguments#1077

Merged
DavidS merged 1 commit intopuppetlabs:masterfrom
runejuhl:hint-intersection-fail
Dec 30, 2019
Merged

intersection: show types in exception due to invalid arguments#1077
DavidS merged 1 commit intopuppetlabs:masterfrom
runejuhl:hint-intersection-fail

Conversation

@runejuhl
Copy link
Copy Markdown
Contributor

Makes the exception message a bit more helpful.

@runejuhl runejuhl requested a review from a team as a code owner December 29, 2019 20:16
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 29, 2019

Codecov Report

Merging #1077 into master will increase coverage by 0.91%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1077      +/-   ##
=========================================
+ Coverage    4.54%   5.46%   +0.91%     
=========================================
  Files         183     183              
  Lines        5238    5238              
=========================================
+ Hits          238     286      +48     
+ Misses       5000    4952      -48
Impacted Files Coverage Δ
lib/puppet/parser/functions/intersection.rb 0% <0%> (ø) ⬆️
lib/puppet/type/file_line.rb 96.36% <0%> (+1.81%) ⬆️
lib/puppet/provider/file_line/ruby.rb 62.62% <0%> (+47.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1f055...88d2121. Read the comment docs.

@DavidS DavidS merged commit f1e2e0b into puppetlabs:master Dec 30, 2019
@DavidS DavidS added the bugfix label Dec 30, 2019
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 5.46%. Comparing base (ee1f055) to head (88d2121).

Files with missing lines Patch % Lines
lib/puppet/parser/functions/intersection.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1077      +/-   ##
=========================================
+ Coverage    4.54%   5.46%   +0.91%     
=========================================
  Files         183     183              
  Lines        5238    5238              
=========================================
+ Hits          238     286      +48     
+ Misses       5000    4952      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants